Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Remove vectorset storage key hack on KB creation #2797

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Jan 21, 2025

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team January 21, 2025 14:15
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (96333d4) to head (ce28fe3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2797      +/-   ##
==========================================
+ Coverage   85.55%   87.08%   +1.52%     
==========================================
  Files         388      388              
  Lines       24553    24562       +9     
==========================================
+ Hits        21006    21389     +383     
+ Misses       3547     3173     -374     
Flag Coverage Δ
nucliadb 74.78% <ø> (+2.86%) ⬆️
nucliadb-ingest 40.39% <ø> (-0.01%) ⬇️
nucliadb-reader 42.92% <ø> (+<0.01%) ⬆️
nucliadb-search 44.01% <ø> (+<0.01%) ⬆️
nucliadb-standalone 47.59% <ø> (+0.02%) ⬆️
nucliadb-train 45.66% <ø> (+<0.01%) ⬆️
nucliadb-writer 46.11% <ø> (+<0.01%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.62% <ø> (ø)
nucliadb_sdk 80.11% <ø> (ø)
nucliadb_sidecar 89.03% <ø> (+1.78%) ⬆️
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants