Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support synchronous chat response #1331

Merged

Conversation

vangheem
Copy link
Contributor

Description

Allow synchronous chat responses.

This includes a refactor to make supporting this more tenable

How was this PR tested?

Describe how you tested this PR.

@vangheem vangheem requested a review from a team as a code owner September 12, 2023 21:36
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #7131: Option to get the /chat response in one go.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 99.28% and project coverage change: +0.11% 🎉

Comparison is base (7bdaa03) 85.08% compared to head (d0ea553) 85.20%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   85.08%   85.20%   +0.11%     
==========================================
  Files         414      415       +1     
  Lines       22885    22922      +37     
==========================================
+ Hits        19472    19530      +58     
+ Misses       3413     3392      -21     
Flag Coverage Δ
ingest 74.91% <ø> (ø)
nucliadb 65.82% <93.52%> (+0.20%) ⬆️
reader 74.08% <ø> (ø)
sdk 42.51% <ø> (ø)
search 83.83% <54.68%> (+0.17%) ⬆️
standalone 82.97% <ø> (ø)
train 60.25% <ø> (ø)
utils 84.63% <ø> (ø)
writer 84.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nucliadb/nucliadb/search/search/find.py 95.83% <95.83%> (ø)
nucliadb/nucliadb/search/api/v1/chat.py 98.03% <100.00%> (ø)
nucliadb/nucliadb/search/api/v1/find.py 97.36% <100.00%> (+0.75%) ⬆️
nucliadb/nucliadb/search/api/v1/resource/chat.py 96.00% <100.00%> (+41.83%) ⬆️
nucliadb/nucliadb/search/search/chat/query.py 95.52% <100.00%> (+2.34%) ⬆️
...adb/search/tests/unit/api/v1/resource/test_chat.py 95.83% <100.00%> (ø)
...adb/nucliadb/search/tests/unit/api/v1/test_chat.py 95.83% <100.00%> (ø)
...search/tests/unit/search/search/chat/test_query.py 100.00% <100.00%> (ø)
nucliadb/nucliadb/tests/integration/test_chat.py 96.20% <100.00%> (+0.61%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangheem vangheem added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 7884805 Sep 13, 2023
@vangheem vangheem deleted the nathanvangheem/sc-7131/option-to-get-the-chat-response-in-one-go branch September 13, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants