Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Updates golang lint config to v2 #3436

Merged
nickzelei merged 13 commits into from
Mar 28, 2025
Merged

Updates golang lint config to v2 #3436

nickzelei merged 13 commits into from
Mar 28, 2025

Conversation

@nickzelei
Copy link
Member

@nickzelei nickzelei commented Mar 28, 2025

No description provided.

@nickzelei nickzelei added the Devex Created by Linear-GitHub Sync label Mar 28, 2025
@vercel
Copy link

vercel bot commented Mar 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2025 9:29pm

nickzelei
nickzelei commented Mar 28, 2025
View reviewed changes
.golangci.yaml
enable:
- gofmt
- goimports
- golines
Copy link
Member Author

@nickzelei nickzelei Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many of the changes are from this.

@codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.84840% with 4728 lines in your changes missing coverage. Please review.

Project coverage is 24.18%. Comparing base (e7958f3) to head (653da3f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/pkg/sqlmanager/mysql/mysql-manager.go 0.00% 288 Missing ⚠️
...ackend/pkg/sqlmanager/postgres/postgres-manager.go 0.00% 279 Missing ⚠️
...rvices/mgmt/v1alpha1/user-account-service/users.go 0.00% 225 Missing ⚠️
backend/internal/ee/hooks/accounts/service.go 0.00% 211 Missing ⚠️
backend/services/mgmt/v1alpha1/job-service/jobs.go 0.00% 187 Missing ⚠️
backend/services/mgmt/v1alpha1/job-service/runs.go 0.00% 186 Missing ⚠️
internal/javascript/functions/benthos/functions.go 12.30% 163 Missing and 8 partials ⚠️
internal/benthos/benthos-builder/builders/sql.go 0.00% 138 Missing ⚠️
internal/connectiondata/sql.go 0.00% 130 Missing ⚠️
internal/schema-manager/mysql/mysql.go 0.00% 127 Missing ⚠️
... and 141 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3436      +/-   ##
==========================================
+ Coverage   24.13%   24.18%   +0.04%     
==========================================
  Files         417      417              
  Lines       50135    54688    +4553     
==========================================
+ Hits        12099    13224    +1125     
- Misses      36897    40325    +3428     
  Partials     1139     1139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Mar 28, 2025 •
edited
Loading

Benchstat Geomean Results

0.65% sec/op, 0.01% B/op, 0.00% allocs/op

Benchstat results 
                                                                 │ main-benchmark.txt │        branch-benchmark.txt        │
                                                                 │       sec/op       │   sec/op     vs base               │
CleanPostgresType-4                                                      42.66n ±  9%   44.84n ± 7%        ~ (p=0.121 n=6)
CleanMysqlType-4                                                         53.94n ±  0%   54.28n ± 1%        ~ (p=0.238 n=6)
Runner_Single-4                                                          7.701µ ±  3%   7.779µ ± 3%        ~ (p=0.310 n=6)
GenerateBool-4                                                           11.54n ±  1%   11.69n ± 4%        ~ (p=0.294 n=6)
GenerateBusinessName-4                                                   304.1n ±  9%   317.4n ± 3%        ~ (p=0.485 n=6)
GenerateCardNumber-4                                                     28.96n ±  6%   28.93n ± 0%        ~ (p=0.305 n=6)
GenerateCategorical-4                                                    93.68n ±  1%   93.27n ± 0%        ~ (p=0.310 n=6)
GenerateCity-4                                                           173.3n ±  2%   174.4n ± 1%        ~ (p=0.056 n=6)
GenerateCountry-4                                                        95.17n ±  2%   95.12n ± 1%        ~ (p=0.394 n=6)
GenerateEmail-4                                                          1.309µ ±  2%   1.307µ ± 0%        ~ (p=0.329 n=6)
GenerateFirstName-4                                                      203.3n ±  0%   204.6n ± 1%   +0.66% (p=0.013 n=6)
GenerateFloat64-4                                                        26.39n ±  1%   26.45n ± 0%        ~ (p=0.091 n=6)
GenerateFullAddress-4                                                    1.411µ ±  0%   1.420µ ± 0%   +0.67% (p=0.006 n=6)
GenerateFullName-4                                                       1.204µ ±  2%   1.340µ ± 4%  +11.30% (p=0.002 n=6)
GenerateGender-4                                                         36.69n ±  0%   36.88n ± 1%   +0.53% (p=0.011 n=6)
GenerateInt64-4                                                          27.02n ±  0%   27.14n ± 0%   +0.43% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                                               51.15n ±  0%   51.22n ± 0%        ~ (p=0.416 n=6)
GenerateInternationalPhoneNumber-4                                       174.2n ±  0%   174.6n ± 1%   +0.26% (p=0.043 n=6)
GenerateIpAddress-4                                                      560.0n ±  2%   552.6n ± 1%   -1.33% (p=0.015 n=6)
GenerateLastName-4                                                       189.2n ±  1%   192.6n ± 1%   +1.80% (p=0.009 n=6)
GenerateRandomString-4                                                   264.9n ± 24%   267.1n ± 0%        ~ (p=0.307 n=6)
GenerateSHA256Hash-4                                                     1.004µ ±  1%   1.005µ ± 0%        ~ (p=0.768 n=6)
GenerateSSN-4                                                            265.8n ±  3%   265.1n ± 0%        ~ (p=0.195 n=6)
GenerateState-4                                                          94.77n ±  2%   95.14n ± 0%        ~ (p=0.394 n=6)
GenerateStreetAddress-4                                                  207.5n ±  1%   206.7n ± 2%        ~ (p=0.725 n=6)
GenerateStringPhoneNumber-4                                              171.1n ±  0%   170.7n ± 1%        ~ (p=0.165 n=6)
GenerateUnixTimestamp-4                                                  77.04n ±  1%   76.77n ± 0%        ~ (p=0.310 n=6)
GenerateUsername-4                                                       346.1n ±  2%   354.8n ± 2%   +2.51% (p=0.004 n=6)
GenerateUTCTimestamp-4                                                   105.8n ±  1%   105.7n ± 0%        ~ (p=0.870 n=6)
GenerateUUID-4                                                           732.1n ±  1%   733.1n ± 0%        ~ (p=0.732 n=6)
GenerateZipcode-4                                                        93.42n ±  1%   93.53n ± 0%        ~ (p=0.394 n=6)
TransformCharacterScramble-4                                             159.9n ±  3%   160.1n ± 1%        ~ (p=0.732 n=6)
TransformE164PhoneNumber-4                                               171.6n ±  0%   171.9n ± 0%        ~ (p=0.554 n=6)
TransformEmail-4                                                         1.774µ ±  1%   1.769µ ± 1%        ~ (p=0.284 n=6)
TransformFirstName-4                                                     233.9n ±  1%   236.0n ± 1%   +0.85% (p=0.017 n=6)
TransformFloat64-4                                                       101.2n ±  1%   101.5n ± 2%   +0.25% (p=0.050 n=6)
TransformFullName-4                                                      1.236µ ±  2%   1.278µ ± 3%   +3.36% (p=0.004 n=6)
TransformInt64-4                                                         31.92n ±  2%   31.90n ± 0%        ~ (p=0.420 n=6)
TransformInt64PhoneNumber-4                                              57.88n ±  3%   58.06n ± 0%        ~ (p=0.394 n=6)
TransformLastName-4                                                      194.8n ±  1%   196.8n ± 2%   +1.00% (p=0.004 n=6)
TransformString-4                                                        291.5n ±  1%   292.7n ± 2%   +0.38% (p=0.011 n=6)
TransformStringPhoneNumber-4                                             198.8n ±  1%   198.6n ± 0%   -0.10% (p=0.022 n=6)
TransformUuid-4                                                          32.34n ±  0%   32.43n ± 1%        ~ (p=0.097 n=6)
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4                82.86n ±  0%   82.17n ± 2%        ~ (p=0.065 n=6)
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4             259.2n ±  3%   256.2n ± 1%   -1.16% (p=0.026 n=6)
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4            1.882µ ±  0%   1.869µ ± 0%   -0.66% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4              199.7n ±  0%   198.4n ± 0%   -0.65% (p=0.009 n=6)
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                 3.736n ±  2%   3.739n ± 0%        ~ (p=0.331 n=6)
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                   14.95µ ±  0%   14.97µ ± 1%        ~ (p=1.000 n=6)
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4            14.95µ ±  2%   14.98µ ± 1%        ~ (p=1.000 n=6)
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4         26.66µ ±  1%   26.68µ ± 1%        ~ (p=0.818 n=6)
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4              26.59µ ±  1%   27.01µ ± 2%   +1.55% (p=0.002 n=6)
geomean                                                                  240.5n         242.0n        +0.65%

                                                                 │ main-benchmark.txt │         branch-benchmark.txt         │
                                                                 │        B/op        │     B/op      vs base                │
CleanPostgresType-4                                                      0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
CleanMysqlType-4                                                         0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                                                        2.290Ki ± 1%     2.300Ki ± 4%       ~ (p=0.509 n=6)
GenerateBool-4                                                           0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                                                   304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                                                     8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                                                    64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                                                           160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                                                        24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                                                          385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                                                      208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                                                        8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                                                    512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                                                       418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                                                         16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                                                          7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                                               8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4                                       40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                                                      31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                                                       176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                                                   72.00 ± 0%       72.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                                                     288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                                                            46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                                                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                                                  240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                                              40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                                                  8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                                                       205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                                                   24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                                                           80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                                                        24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4                                             40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                                               40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                                                         489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                                                     224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                                                       88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                                                      418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                                                         8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                                              8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                                                      176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                                                        88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4                                             56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                                                          16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4                6.000 ± 0%       6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4             61.00 ± 0%       61.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4            582.0 ± 0%       582.0 ± 0%       ~ (p=1.000 n=6)
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4              64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                 0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                 34.43Ki ± 0%     34.42Ki ± 1%       ~ (p=0.818 n=6)
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4          34.44Ki ± 0%     34.40Ki ± 0%       ~ (p=0.784 n=6)
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4       64.00Ki ± 0%     64.00Ki ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4            64.00Ki ± 0%     64.00Ki ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                                             ²                 +0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                                                 │ main-benchmark.txt │        branch-benchmark.txt         │
                                                                 │     allocs/op      │  allocs/op   vs base                │
CleanPostgresType-4                                                     0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
CleanMysqlType-4                                                        0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                                                         24.00 ±  0%     24.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                                                          0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                                                  2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                                                    1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                                                   2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                                                          2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                                                       2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                                                         8.000 ±  0%     8.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                                                       1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                                                   10.00 ±  0%     10.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                                                      6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                                                        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                                                         0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                                              1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4                                      3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                                                      2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                                                  2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                                                    7.000 ±  0%     7.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                                                           3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateState-4                                                         2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                                                 2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                                             3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                                                 1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                                                      6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                                                  1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                                                          3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                                                       2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4                                            3.000 ± 33%     3.000 ± 33%       ~ (p=1.000 n=6)
TransformE164PhoneNumber-4                                              3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                                                        14.00 ±  0%     14.00 ±  0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                                                    3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                                                      3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                                                     6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                                                        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                                             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformString-4                                                       3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4                                            4.000 ±  0%     4.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                                                         1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4               1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4            1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4           1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                  1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4           1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
geomean                                                                             ²                +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@nickzelei nickzelei merged commit 88a0ba6 into main Mar 28, 2025
16 of 17 checks passed
@nickzelei nickzelei deleted the nick/fix-golanglint branch March 28, 2025 22:00
@BrewTestBot BrewTestBot mentioned this pull request Apr 2, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alishakawaguchi alishakawaguchi alishakawaguchi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Devex Created by Linear-GitHub Sync

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickzelei @alishakawaguchi