This repository was archived by the owner on Aug 30, 2025. It is now read-only.
NEOS-1787: add auto map support to mysql #3412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
nickzelei
commented
Mar 26, 2025
| c.TABLE_SCHEMA AS schema_name, | ||
| c.TABLE_NAME AS table_name, | ||
| c.COLUMN_NAME AS column_name, | ||
| c.COLUMN_TYPE AS data_type, |
Member
Author
There was a problem hiding this comment.
this is kinda weird. the above query we are using c.data_type but this one we are using c.column_type which is different. I didnt want to update it at the expense of potentially causing a bux.
nickzelei
commented
Mar 26, 2025
| c.TABLE_NAME AS table_name, | ||
| c.COLUMN_NAME AS column_name, | ||
| c.COLUMN_TYPE AS data_type, | ||
| c.COLUMN_TYPE AS column_type, -- same as data_type but includes things like the length, or set/enum information |
Member
Author
There was a problem hiding this comment.
@alishakawaguchi - This column_type properly tracks mysql set and enum values. So I'm guessing that the mysql schema drift changes won't track if this changes. I created a ticket for this: NEOS-1791
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3412 +/- ##
==========================================
- Coverage 24.32% 24.24% -0.09%
==========================================
Files 417 417
Lines 49405 49856 +451
==========================================
+ Hits 12020 12089 +69
- Misses 36251 36631 +380
- Partials 1134 1136 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchstat Geomean Results-8.14% sec/op, -4.17% B/op, -0.68% allocs/op Benchstat results |
alishakawaguchi
approved these changes
Mar 26, 2025
…to-map-support-to-mysql
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.