button_group #512
Open
button_group #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you motivate your changes ? |
|
Do not worry about the CI failure I will take care of it. |
|
Thank you |
|
Reading through your changes it seems you have misinterpreted the goal of the example, which means it can be improved. This example demonstrate how radio buttons living in different containers can still be grouped. Radio buttons living in the same container are grouped by default which is not demonstrated by this example and maybe it should. Your changes make use of this mechanism but completely remove the original intent of the example. We should try to expand the example to do both: demonstrate the default behavior and the more flexible one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.