fix(amazon-cognito-identity-js): add "none" to sameSite possible valu…

…es (aws-amplify#6682) * add none to cookiesStorage sameSite possible values * add sameSite = none to the valid values * update ICookieStorageData interface update ICookieStorageData to support sameSite = 'none' * Update packages/amazon-cognito-identity-js/src/CookieStorage.js Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
nubpro · Oct 2, 2020 · 0e6a374 · 0e6a374
1 parent 2206ede
commit 0e6a374
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/amazon-cognito-identity-js/index.d.ts b/packages/amazon-cognito-identity-js/index.d.ts
diff --git a/packages/amazon-cognito-identity-js/src/CookieStorage.js b/packages/amazon-cognito-identity-js/src/CookieStorage.js
@@ -33,9 +33,14 @@ export default class CookieStorage {
 			this.secure = true;
 		}
 		if (Object.prototype.hasOwnProperty.call(data, 'sameSite')) {
-			if (data.sameSite !== 'strict' && data.sameSite !== 'lax') {
+			if (!['strict','lax','none'].includes(data.sameSite)) {
 				throw new Error(
-					'The sameSite value of cookieStorage must be "lax" or "strict".'
+					'The sameSite value of cookieStorage must be "lax", "strict" or "none".'
+				);
+			}
+			if (data.sameSite === 'none' && !this.secure) {
+				throw new Error(
+					'sameSite = None requires the Secure attribute in latest browser versions.'
 				);
 			}
 			this.sameSite = data.sameSite;