Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused requirement #85

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Remove unused requirement #85

merged 3 commits into from
Jul 25, 2019

Conversation

caique-lima
Copy link
Contributor

Status

READY

Description of the changes proposed in the pull request

Removed unused requirement

@caique-lima caique-lima added this to the 1.15.x milestone Jul 25, 2019
@caique-lima caique-lima added enhancement New feature or request review-request Waiting to be reviewed labels Jul 25, 2019
@caique-lima caique-lima requested a review from dieggoluis July 25, 2019 18:44
@codecov-io
Copy link

codecov-io commented Jul 25, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@58d30ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage          ?   94.69%           
=========================================
  Files             ?       25           
  Lines             ?     1547           
  Branches          ?      220           
=========================================
  Hits              ?     1465           
  Misses            ?       48           
  Partials          ?       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d30ae...b743fcb. Read the comment docs.

@dieggoluis
Copy link
Contributor

dieggoluis commented Jul 25, 2019 •
edited
Loading

@caique-lima do you want to remove scikit-learn dependency? 🤔

dieggoluis
dieggoluis approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@dieggoluis dieggoluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caique-lima caique-lima merged commit e81560d into nubank:master Jul 25, 2019
@caique-lima caique-lima deleted the remove-sckit-image branch July 25, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dieggoluis dieggoluis dieggoluis approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request review-request Waiting to be reviewed
Projects
None yet
Milestone
1.15.x
Development

Successfully merging this pull request may close these issues.
3 participants
@caique-lima @codecov-io @dieggoluis