Allow latest versions of dependencies #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 28, 2021 16:53
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 94.69% 94.24% -0.45%
==========================================
Files 25 32 +7
Lines 1507 1928 +421
Branches 203 258 +55
==========================================
+ Hits 1427 1817 +390
- Misses 48 76 +28
- Partials 32 35 +3
Continue to review full report at Codecov.
|
tatasz
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Todo list
Background context
Most of the versions were added many months ago, and their breaking changes were mostly due to the drop of support to Python 2.7 and 3.5.
Description of the changes proposed in the pull request
shap, whose version is less than 1, so it can be considered experimental.catboost,lightgbm,xgboost,shap,swifter(mostly due to deprecation of support to Python 3.5 and older versions). Libraries depending onfklearncan still restrict the versions of the aforementioned libraries, keeping the previous behavior.Remaining problems or questions
Since many libraries were bumped, and the test coverage may not be sufficient, it is possible that things break. In that case, we will first try to fix the code, and as second attempt we will restrict the library version.