Open
Conversation
|
think some base urls are not https://clubs.ntu.edu.sg/csec so they arent being changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the script for image upload.
Fixes implemented
1. Adapt to strapiv4 api
existing.body->existing.attributes.body_put(`/api/posts/${existing.id}`, existing )->_put(`/api/posts/${existing.id}`, { data: existing.attributes })/upload->/api/upload2. Handle the absence of
attachment_collection.jsonfile3. Fix image urls that do not start with
https://clubs.ntu.edu.sg/csec/not being uploadedRemove the following code:
4. Fix placeholder image not being copied correctly
5. Added 2 folders in image uploads:
successandfail6. Fix GET posts returning only 25 posts at a time
Instead of fetching the the list of posts at the start, fetch the post one at a time with a filter:
[SCSE-105]