Skip to content

Conversation

@Eleven1Liu
Copy link
Contributor

@Eleven1Liu Eleven1Liu commented Aug 14, 2025

What does this PR do?

  • Remove class variable word_dict from Model as it is unrelated to training and not used by huggingface transformers.
  • Alternatively, save it to checkpoint_path/word_dict.pickle (e.g., runs/xxx/word_dict.pickle)
  • Update related codes and documents.

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Eleven1Liu Eleven1Liu added the documentation Improvements or additions to documentation label Aug 16, 2025
@Eleven1Liu Eleven1Liu marked this pull request as ready for review August 19, 2025 13:14
@Eleven1Liu Eleven1Liu requested review from a team and cjlin1 as code owners August 19, 2025 13:14
@Eleven1Liu Eleven1Liu merged commit c473d48 into ntumlgroup:master Aug 22, 2025
1 check passed
@Eleven1Liu Eleven1Liu deleted the free_worddict branch August 26, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation model/nn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants