Skip to content

Fix what seems to be a minor assignment issue #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix what seems to be a minor assignment issue #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions broccoli-angular-templates-cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function transformTemplateEntry(entry, strip, prepend, minify) {
var path = entry.path,
content = entry.content,
parseError;

// Normalize windows only
if (process.platform === 'win32') {
path = path.replace(/\\/g, '/');
Expand Down Expand Up @@ -67,6 +67,7 @@ var BroccoliAngularTemplateCache = function BroccoliAngularTemplateCache(inTree,
}
this.inputTree = inTree;
this.options = options || {};

CachingWriter.apply(this, arguments);
};
BroccoliAngularTemplateCache.prototype = Object.create(CachingWriter.prototype);
Expand All @@ -75,23 +76,23 @@ BroccoliAngularTemplateCache.prototype.description = 'angular templates cache';


BroccoliAngularTemplateCache.prototype.updateCache = function(srcDir, destDir) {

var self = this;
var templates = [];

// normalize options
var options = {
minify : self.options.minify || false,
prepend : self.options.prepend || false,
strip : self.options.strip || false,
moduleName : self.options.moduleName,
minify : self.minify || false,
prepend : self.prepend || false,
strip : self.strip || false,
moduleName : self.moduleName,
firstFile : null,
srcDir : self.options.srcDir || './',
fileName : self.options.fileName || 'template-cache.js',
destDir : self.options.destDir || './',
srcDir : self.srcDir || './',
fileName : self.fileName || 'template-cache.js',
destDir : self.destDir || './',
absolute : self.options.absolute || false
};

var src = path.join(srcDir[0], options.srcDir);
var dest = path.join(destDir, options.destDir, options.fileName);

Expand All @@ -105,7 +106,7 @@ BroccoliAngularTemplateCache.prototype.updateCache = function(srcDir, destDir) {
if(! options.absolute){
var file = fileLocation.replace(path.normalize(src), '');
}

templates.push({
path: file || fileLocation,
content: fs.readFileSync(fileLocation).toString('utf-8')
Expand Down