Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax @nestjs/graphql optional dependency #58

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

holm
Copy link
Contributor

@holm holm commented Sep 21, 2021

This relaxes the optional dependency, so @nestjs/graphql v9 can be used

@andreialecu
Copy link

Note that optionalDependencies is incorrect here, that is only for optional native modules.

This should be defined using peerDependencies and peerDependenciesMeta to mark it optional.

See: https://stackoverflow.com/questions/62047806/optional-peer-dependency/66228639

@ntegral ntegral merged commit 6eb0cbf into ntegral:master Oct 25, 2021
@ntegral
Copy link
Owner

ntegral commented Oct 25, 2021

@holm thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants