Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TTL to 0 for subdomains #41

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Set TTL to 0 for subdomains #41

merged 1 commit into from
Aug 17, 2020

Conversation

nt0xa
Copy link
Owner

@nt0xa nt0xa commented Aug 17, 2020

In some of previous commits TTL for some records was set to 600 which breaks DNS notifications

@nt0xa nt0xa added the fix Bug fix label Aug 17, 2020
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   75.59%   75.59%           
=======================================
  Files          42       42           
  Lines        1639     1639           
=======================================
  Hits         1239     1239           
  Misses        273      273           
  Partials      127      127           
Impacted Files Coverage Δ
internal/handlers/dnsx/static.go 79.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db29ab3...4f09e4e. Read the comment docs.

@nt0xa nt0xa merged commit 65c8ed2 into master Aug 17, 2020
@nt0xa nt0xa deleted the fix/dns-ttl branch August 17, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant