fix: Fix DNS round robin response (#39)

* Fix DNS round robin response * Remove debug print * Improve tests to catch this bug
nt0xa · Jul 17, 2020 · ba7d3e1 · ba7d3e1
1 parent 55c2738
commit ba7d3e1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/handlers/dnsx/handler.go b/internal/handlers/dnsx/handler.go
@@ -34,7 +34,7 @@ func (h *DNSX) handleFunc(w dns.ResponseWriter, r *dns.Msg) {
 
 			case models.DNSStrategyRoundRobin:
 				if rec.LastAnswer != nil {
-					msg.Answer = rotate(rec.LastAnswerRRs(h.origin))
+					msg.Answer = rotate(rec.LastAnswerRRs(origin))
 				} else {
 					msg.Answer = rec.RRs(origin)
 				}

diff --git a/internal/handlers/dnsx/handler_test.go b/internal/handlers/dnsx/handler_test.go
@@ -114,6 +114,7 @@ func TestDNSMgr(t *testing.T) {
 
 				for j, a := range in.Answer {
 					assert.Contains(t, a.String(), tt.results[i][j])
+					assert.Equal(t, a.Header().Name, tt.name)
 				}
 			}
 		})
-Original file line number
+Diff line change
@@ Expand Up / @@ -114,6 +114,7 @@ func TestDNSMgr(t *testing.T) { @@
     				for j, a := range in.Answer {
     					assert.Contains(t, a.String(), tt.results[i][j])
+    					assert.Equal(t, a.Header().Name, tt.name)
     				}
     			}
     		})
@@ Expand Down @@