Skip to content
This repository was archived by the owner on Dec 19, 2021. It is now read-only.

fix(loading-indicator.ios): allow message to line break in iOS #43

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix(loading-indicator.ios): allow message to line break in iOS #43

merged 1 commit into from
Mar 23, 2020

Conversation

jasonfrasch
Copy link
Contributor

PR Checklist

What is the current behavior?

Long messages do not line break in iOS

What is the new behavior?

Long messages will break to the next line in iOS

Fixes #42

@jasonfrasch
Copy link
Contributor Author

Not sure what to do for testing coverage, do you have suggestions?

@bradmartin
Copy link
Collaborator

For now, no worry on the tests. We just have a simple app build in place, sadly, no time for test coverage for all the plugins/APIs we have. Would love to get to it, but not a priority at the moment.

Thanks for the PR by the way, I'll try to bump this out shortly as a bug release

@bradmartin bradmartin merged commit 0f915d3 into nstudio:master Mar 23, 2020
@jasonfrasch
Copy link
Contributor Author

You're welcome, glad I could help (even if it's just a little)

@jasonfrasch jasonfrasch deleted the patch-1 branch March 23, 2020 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long messages do not line break in iOS
2 participants