Skip to content

Give the card name round-trip test a 20 s timeout - #366

Merged
nstarman merged 1 commit into
mainfrom
fix/cards-roundtrip-timeout
Oct 8, 2026
Merged

nstarman merged 1 commit into
mainfrom
fix/cards-roundtrip-timeout

Conversation

@nstarman

@nstarman nstarman commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Changing code or schema

What and why:

tests/cards.test.js > the grammar, at its edges > writes every name it reads as one it reads back the same failed twice in npm test on 2026-10-08 and passed on every re-run. The cause is a timeout, not the grammar:

  • --testTimeout=300 reproduces it exactly: Error: Test timed out in 300ms.
  • Alone, the test takes ~760 ms. With all cores busy it took 1.4–1.8 s, and with four full suites running at once 3.0–3.4 s, closing on vitest's 5 s default. The walk is seeded, so a real round-trip bug would fail every run, not some of them.
  • All 3000 generated names parse and all 3000 are distinct, so every iteration covers something and cutting the count would cut coverage.

So this test alone gets an explicit 20_000 ms timeout. The iteration count stays at 3000.

No screenshots: this only changes a test, and the site is unchanged.

  • npm test passes (unit, schema, bibtex, build, a11y, links)
  • If a link.rel value or a type was added… n/a
  • If a constraint was added… n/a

🤖 Generated with Claude Code

The seeded walk builds 3000 names, all distinct and all parsed, so each
iteration is real coverage. It takes under 1 s alone but over 3 s with
the machine busy, which on 2026-10-08 ran past vitest's 5 s default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nstarman nstarman added this to the ♾️&➡ milestone Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Preview: https://64195584.nstarkman-space.pages.dev

Built from 4b57c2ac01e06ee79b81d57904b313b84f6a1b4e, including the four CV PDFs.
Updated on every push to this pull request.

@nstarman
nstarman merged commit 22ad93f into main Oct 8, 2026
8 checks passed
@nstarman
nstarman deleted the fix/cards-roundtrip-timeout branch October 8, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant