refactor(#46): Singleton NStack instance to expose business logic features #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johsoe
approved these changes
Dec 9, 2022
nivisi
deleted the
refactor/#46-singleton-nstack-instance-to-expose-business-logic-features
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46
NStackwas renamed toNStackSdk, localization was moved to a separate class,NStackLocalizationNStackis now a global variable of typeNStackSdkI feel like
NStackSdkandNStackLocalizationneed some refactoring to make the code cleaner — but that's a separate ticket.Also, atm if you change the language from the domain layer by doing
NStack.localization.changeLocalization(locale), the UI won't be updated. It's not complex to implement, but I'd like to move it to a separate ticket. (update: here it is #50)