lib/freebl/genload.c: drop call to PR_SetError #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop call to PR_SetError in genload.c as already done in lowhash_vector.c to avoid adding a dependency on a function defined in nspr and raising the following build failure when FREEBL_NO_DEPEND is set to 1 (default on Linux): /home/buildroot/autobuild/instance-3/output-1/host/bin/microblazeel-linux-gcc -shared -Wl,-z,defs -Wl,-soname -Wl,libfreebl3.so -Wl,--version-script,Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/freebl.def -Wl,-Bsymbolic -o Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/libfreebl3.so Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/lowhash_vector.o -ldl -lc /home/buildroot/autobuild/instance-3/output-1/host/opt/ext-toolchain/bin/../lib/gcc/microblazeel-buildroot-linux-musl/11.2.0/../../../../microblazeel-buildroot-linux-musl/bin/ld: Linux2.6_microblazeel_microblazeel-linux-gcc.br_real_glibc_PTH_DBG.OBJ/Linux_SINGLE_SHLIB/lowhash_vector.o: in function `loader_GetOriginalPathname': (.text.loader_GetOriginalPathname+0x1c4): undefined reference to `PR_SetError' Fixes: - http://autobuild.buildroot.org/results/d00d22f1bfee5c175f3266ff16124632906463c3 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop call to
PR_SetErroringenload.cas already done inlowhash_vector.cto avoid adding a dependency on a function defined in nspr and raising the following build failure whenFREEBL_NO_DEPENDis set to 1 (default on Linux):Fixes: