Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDENTIFY: send 1.0 compatible client_id and hostname fields #169

Merged
merged 2 commits into from
Feb 22, 2017
Merged

IDENTIFY: send 1.0 compatible client_id and hostname fields #169

merged 2 commits into from
Feb 22, 2017

Conversation

jehiah
Copy link
Member

@jehiah jehiah commented Feb 21, 2017

This adds support for new IDENTIFY fields as support for the old fields was removed from nsqd in nsqio/nsq#367

@jehiah jehiah added the bug label Feb 21, 2017
@mreiferson
Copy link
Member

we're good at computers

@mreiferson mreiferson self-requested a review February 21, 2017 22:22
mreiferson
mreiferson approved these changes Feb 21, 2017
View reviewed changes
Copy link
Member

@mreiferson mreiferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jehiah jehiah merged commit ed7ef0d into nsqio:master Feb 22, 2017
@dudleycarr dudleycarr mentioned this pull request Feb 22, 2017
Closed
@mreiferson mreiferson deleted the client_id_169 branch March 29, 2017 03:02
@ploxiln ploxiln mentioned this pull request Dec 11, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreiferson mreiferson mreiferson approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jehiah @mreiferson