-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ability to administratively create topics/channels #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
couple talking points:
cc @bitly/nsq |
ok, whole bunch of changes... went in the direction of this solving the more important case of being able to setup your stream hierarchy before deployment. the individual endpoints for the various daemons can be used to one-off channel and topic creation. also did some style improvements cc @bitly/nsq |
ready @jehiah |
good set of changes. squash please. |
* refactor util.ReqParams to embed url.Values (but still support Get() that returns error to distinguish between a missing key from an empty one. s/Query/Get. add GetAll() * go fmt cc @danielhfrank :) * fix capitalization of lookupd helper method for consistency
* tweak some styles * add /lookup page to see inactive topics/channels and create new ones * add auto-update big graph to counter page
k, squashed... a bit 😄 |
jehiah
added a commit
that referenced
this pull request
Nov 13, 2012
ability to administratively create topics/channels
arussellsaw
pushed a commit
to arussellsaw/nsq
that referenced
this pull request
Mar 5, 2018
config should accept tls-client-cert
absolute8511
added a commit
to absolute8511/nsq
that referenced
this pull request
Jan 12, 2023
Optimize code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for certain operational scenarios it would be helpful to be able to create topics/channels via
nsqadmin
cc @jehiah