Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to administratively create topics/channels #75

Merged
merged 5 commits into from
Nov 13, 2012

Conversation

mreiferson
Copy link
Member

for certain operational scenarios it would be helpful to be able to create topics/channels via nsqadmin

cc @jehiah

@mreiferson
Copy link
Member Author

couple talking points:

  1. I chose to just allow nsqd to propagate information to nsqlookupd for these creation events, no specific HTTP endpoints are added for creation in nsqlookupd
  2. where should create topic go in the UI (for testing I just put it on the index page)? Relatedly, you need to select your producers when you're creating a topic so a multi-select made sense to me but can be clumsy to work with for large #s of nodes.

cc @bitly/nsq

@mreiferson
Copy link
Member Author

ok, whole bunch of changes... went in the direction of this solving the more important case of being able to setup your stream hierarchy before deployment.

the individual endpoints for the various daemons can be used to one-off channel and topic creation.

also did some style improvements

cc @bitly/nsq

@mreiferson
Copy link
Member Author

ready @jehiah

@jehiah
Copy link
Member

jehiah commented Nov 13, 2012

good set of changes. squash please.

* refactor util.ReqParams to embed url.Values (but still support
  Get() that returns error to distinguish between a missing key
  from an empty one.  s/Query/Get. add GetAll()
* go fmt cc @danielhfrank :)
* fix capitalization of lookupd helper method for consistency
* tweak some styles
* add /lookup page to see inactive topics/channels and create
  new ones
* add auto-update big graph to counter page
@mreiferson
Copy link
Member Author

k, squashed... a bit 😄

jehiah added a commit that referenced this pull request Nov 13, 2012
ability to administratively create topics/channels
@jehiah jehiah merged commit fced0f3 into nsqio:master Nov 13, 2012
arussellsaw pushed a commit to arussellsaw/nsq that referenced this pull request Mar 5, 2018
config should accept tls-client-cert
absolute8511 added a commit to absolute8511/nsq that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants