Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common test funcs to internal/test #675

Merged
merged 1 commit into from
Oct 28, 2015

Conversation

judwhite
Copy link
Contributor

Promoting some common test functions in the project to its own internal package.

Example Usage:

import (
    "testing"
    "github.com/nsqio/nsq/internal/test"
)

func TestAwesomesauce(t *testing.T) {
    // do some awesomeness
    test.Equal(t, svc.StartPending, changes[0].State)
    test.Nil(t, wsf.ws.getError())
}

@mreiferson
Copy link
Member

LGTM

mreiferson added a commit that referenced this pull request Oct 28, 2015
add common test funcs to internal/test
@mreiferson mreiferson merged commit eb41723 into nsqio:master Oct 28, 2015
@judwhite judwhite deleted the feature/test-package branch October 29, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants