Dockerfile: update base image from alpine:3.10 to latest #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we can just use latest stable alpine release (currently 3.14) also switch build image from golang default (debian-based) to alpine-based, it's smaller and faster to download
ploxiln
force-pushed
the
dockerfile_base_upd
branch
from
1d43cf7
to
f4926f9
Compare
* recent versions of Go do not need GO111MODULE set * PREFIX=/opt/nsq makes as much sense as DESTDIR=/opt PREFIX=/nsq * no need to run test.sh in the same RUN as the build
|
thanks for reviewing! I pushed up another Dockerfile tweak just now, sorry :) fwiw I've tested docker builds with |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can just use latest stable alpine release (currently 3.14)
also switch build image from golang default (debian-based)
to alpine-based, it's smaller and faster to download