Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: build multi-arch docker images linux/amd64,linux/arm64 #1355

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

danbf
Copy link
Contributor

@danbf danbf commented Aug 3, 2021

Problem

current nsq images don't support arm64 architecture. that means we can't run them on AWS Graviton's or Apple M1's natively.

Solution

use buildx to build a multi-arch with linux/amd64,linux/arm64 platform support.

the biggest change is we have to go from separate build and push steps into a single build and push step. this is because the local docker doesn't support building locally multi-arch images.

Notes

based on https://www.docker.com/blog/multi-arch-images/ and https://www.docker.com/blog/multi-arch-build-what-about-circleci/
our upstreams, both golang:latest and alpine:3.10`` support these architectures and more.

addresses: #1306

@danbf danbf force-pushed the multi-arch branch 4 times, most recently from 94f6887 to 7c196d1 Compare August 3, 2021 17:04
@danbf danbf changed the title build multi-arch docker images linux/amd64,linux/arm64,linux/arm/v7 build multi-arch docker images linux/amd64,linux/arm64 Aug 3, 2021
@danbf danbf marked this pull request as ready for review August 3, 2021 18:00
@danbf danbf mentioned this pull request Aug 3, 2021
Copy link
Member

@mreiferson mreiferson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this a test run, seems like a good time for a stable release ;)

dist.sh Outdated Show resolved Hide resolved
@mreiferson mreiferson changed the title build multi-arch docker images linux/amd64,linux/arm64 *: build multi-arch docker images linux/amd64,linux/arm64 Aug 13, 2021
@mreiferson mreiferson merged commit da02d9a into nsqio:master Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants