Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofs-adm: fixes for contract update #984

Merged
merged 3 commits into from
Nov 29, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Nov 24, 2021

  1. Compare NEF.Checksum to check if contract is updated.
  2. Replace addRoot with register in NNS.
  3. Compare hashes written to NNS properly.

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #984 (134bd19) into master (011d0f6) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   38.31%   38.27%   -0.05%     
==========================================
  Files         258      258              
  Lines       13504    13519      +15     
==========================================
  Hits         5174     5174              
- Misses       7898     7913      +15     
  Partials      432      432              
Impacted Files Coverage Δ
...fs-adm/internal/modules/morph/initialize_deploy.go 0.00% <0.00%> (ø)
...neofs-adm/internal/modules/morph/initialize_nns.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 011d0f6...134bd19. Read the comment docs.

@alexvanin
Copy link
Contributor

Add [#984] to commit header.

…was updated

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Don't update if the hash is already there.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
@cthulhu-rider cthulhu-rider merged commit 98f288c into nspcc-dev:master Nov 29, 2021
cthulhu-rider pushed a commit that referenced this pull request Nov 29, 2021
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
cthulhu-rider pushed a commit that referenced this pull request Nov 29, 2021
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
…was updated

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
Don't update if the hash is already there.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants