Skip to content

Prepare for binary header reading#3792

Draft
cthulhu-rider wants to merge 7 commits intomasterfrom
local-head-buffer
Draft

Prepare for binary header reading#3792
cthulhu-rider wants to merge 7 commits intomasterfrom
local-head-buffer

Conversation

@cthulhu-rider
Copy link
Contributor

refactoring part of #3783

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 13.57410% with 694 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.30%. Comparing base (bc322b8) to head (7c6ae5d).
⚠️ Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
internal/protobuf/api.go 0.00% 136 Missing ⚠️
pkg/services/object/acl/eacl/v2/object.go 0.00% 110 Missing ⚠️
internal/protobuf/parsers.go 0.00% 77 Missing ⚠️
internal/object/wire.go 28.73% 57 Missing and 5 partials ⚠️
pkg/local_object_storage/shard/head.go 0.00% 60 Missing ⚠️
pkg/services/object/protobuf.go 19.11% 55 Missing ⚠️
pkg/services/object/server.go 0.00% 40 Missing ⚠️
internal/protobuf/protobuf.go 0.00% 29 Missing ⚠️
pkg/local_object_storage/blobstor/fstree/head.go 60.81% 16 Missing and 13 partials ⚠️
internal/protobuf/buffers.go 0.00% 23 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   25.70%   25.30%   -0.40%     
==========================================
  Files         660      668       +8     
  Lines       42167    43427    +1260     
==========================================
+ Hits        10837    10989     +152     
- Misses      30348    31414    +1066     
- Partials      982     1024      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider force-pushed the local-head-buffer branch 2 times, most recently from f24288c to 1faf301 Compare February 2, 2026 12:04
Going to be used for #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refactoring to get closer to #3783. Behavior is preserved as much as
possible.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refactoring to get closer to #3783. In the future, this will help read
the header directly into the response buffer. Previous behavior is
preserved as much as possible.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refactoring to get closer to #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refs #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refs #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refs #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant