Merged
Conversation
It's the same by default (1s), but otherwise it's not much different from regular cycle when we wait a bit and pick up the next batch afterwards. This code was originally introduced before repCooldown. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
It can be noisy for small tests, but it's useful for real production networks where we'd like to have some hints on policer state. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Right now the log sequence for PUT-with-cache looks like this:
Dec 07 12:27:11 metis1 neofs-node[1649231]: info log/log.go:12 local object storage operation {"shard_id": "9RS1nEyW5xPLjuvagyPRNd", "substorage": "write-cache", "address": "Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/8jdegCjfVG1NNWB1c4haaWcTVW47GhsC4MpHTZ49wUsY", "type": "write-cache", "op": "PUT"}
Dec 07 12:27:11 metis1 neofs-node[1649231]: info log/log.go:12 local object storage operation {"shard_id": "9RS1nEyW5xPLjuvagyPRNd", "address": "Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/8jdegCjfVG1NNWB1c4haaWcTVW47GhsC4MpHTZ49wUsY", "op": "metabase PUT"}
Dec 07 12:27:12 metis1 neofs-node[1649231]: info log/log.go:12 local object storage operation {"shard_id": "9RS1nEyW5xPLjuvagyPRNd", "substorage": "write-cache", "address": "Aku38wpn2xEqfEPxmwyAa7N3VnAkMV8PEVkpLqwKM1z3/8jdegCjfVG1NNWB1c4haaWcTVW47GhsC4MpHTZ49wUsY", "type": "write-cache", "op": "DELETE"}
Obviously, we're missing some PUT to fstree which is added by this patch.
Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
add-useful-logs
branch
from
8d72a1c to
e1bdc2a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3720 +/- ##
=======================================
Coverage 26.87% 26.87%
=======================================
Files 658 658
Lines 41819 41825 +6
=======================================
+ Hits 11239 11241 +2
- Misses 29544 29548 +4
Partials 1036 1036 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.