Merged
Conversation
carpawell
force-pushed
the
fix/ir-shutdown
branch
from
b871931 to
86e51ce
Compare
Member
Author
|
Not sure about the second one. Maybe it is better to panic when |
Do not override `SingleAsyncExecutingInstance`'s stop function. The second one was called twice, while the first one was never called. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3706 +/- ##
==========================================
- Coverage 27.31% 27.30% -0.02%
==========================================
Files 658 658
Lines 41881 41885 +4
==========================================
- Hits 11441 11437 -4
- Misses 29379 29386 +7
- Partials 1061 1062 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
carpawell
requested review from
End-rey,
cthulhu-rider and
roman-khimov
as code owners
carpawell
force-pushed
the
fix/ir-shutdown
branch
from
86e51ce to
11b6eec
Compare
carpawell
force-pushed
the
fix/ir-shutdown
branch
from
11b6eec to
5caf77c
Compare
cthulhu-rider
approved these changes
Nov 27, 2025
roman-khimov
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.