engine: fix flaky shard evacuate test#3605
Merged
roman-khimov merged 1 commit intomasterfrom Sep 30, 2025
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
The test only monitors the last shard and stops when it reaches the target count, but doesn't ensure uniform distribution across all shards. So, there is situation when all 5 objects ended up in the 4th shard (the non-evacuated one), while the first 3 shards (being evacuated) were empty. Since the engine check guarantees that the last shard definitely has objects, we include it in the evacuation list. Closes #3516. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3605 +/- ##
==========================================
+ Coverage 26.69% 26.70% +0.01%
==========================================
Files 655 655
Lines 49749 49744 -5
==========================================
+ Hits 13281 13286 +5
+ Misses 35420 35412 -8
+ Partials 1048 1046 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Sep 29, 2025
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
Can be solved with pushing as many objects as needed to get objPerShard for all shards (maybe other tests have some assumptions as well), but one is OK to fix the test as well.
cthulhu-rider
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3516.