cli/object: stream payload without buffering#3535
Merged
cthulhu-rider merged 4 commits intomasterfrom Aug 21, 2025
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
End-rey
force-pushed
the
1932-use-streams-to-marshalunmarshal-objects-payload
branch
from
2932d0e to
f891c08
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3535 +/- ##
==========================================
+ Coverage 24.68% 24.86% +0.17%
==========================================
Files 672 675 +3
Lines 50052 50129 +77
==========================================
+ Hits 12357 12466 +109
+ Misses 36698 36669 -29
+ Partials 997 994 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
End-rey
force-pushed
the
1932-use-streams-to-marshalunmarshal-objects-payload
branch
from
f891c08 to
8c30d4c
Compare
End-rey
force-pushed
the
1932-use-streams-to-marshalunmarshal-objects-payload
branch
from
8c30d4c to
68bf563
Compare
Do not store the entire payload in memory. For `--binary` input, parse the header prefix to extract metadata and stream the payload directly from the file reader to the client writer (progress proxies only payload). Add shared protobuf wire helpers in `internal/object`, took the code from the fstree logic head, so I also refactored it there. Closes #1932. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
1932-use-streams-to-marshalunmarshal-objects-payload
branch
from
68bf563 to
3001dbc
Compare
Do not store the entire payload in memory, but stream data directly from the client reader to the output writer. Refs #1932. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Defer Close warnings silenced. Refactor progress bar creation. Error string should not be capitalized. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
carpawell
approved these changes
Aug 21, 2025
cthulhu-rider
approved these changes
Aug 21, 2025
cthulhu-rider
deleted the
1932-use-streams-to-marshalunmarshal-objects-payload
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1932.
I was also thinking about making functions in SDK that I made in the helper package.