Makefile: use buildx component to build images with BuildKit
#3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1) Signed-off-by: Andrey Butusov <andrey@nspcc.io>
https://docs.docker.com/engine/deprecated/#legacy-builder-fallback ``` DEPRECATED: The legacy builder is deprecated and will be removed in a future release. Install the buildx component to build images with BuildKit: https://docs.docker.com/go/buildx/ ``` Use `buildx` directly like in the GH workflow. Closes #3006. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3009 +/- ##
=======================================
Coverage 23.06% 23.06%
=======================================
Files 790 790
Lines 58709 58709
=======================================
Hits 13542 13542
Misses 44285 44285
Partials 882 882 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Nov 12, 2024
carpawell
reviewed
Nov 12, 2024
I didn't have any mistake initially. But I set the value |
cthulhu-rider
approved these changes
Nov 13, 2024
roman-khimov
deleted the
3006-buildx-component-to-build-images-with-buildkit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GH workflow uses the build-push-action, where images are built with
buildx. So I made it like this in ourMakefile.Also, fix warnings in Dockerfiles.
Closes #3006.