Feat/control service object list #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
- Coverage 23.91% 23.77% -0.15%
==========================================
Files 776 779 +3
Lines 45721 45995 +274
==========================================
Hits 10936 10936
- Misses 33925 34199 +274
Partials 860 860 ☔ View full report in Codecov by Sentry. |
carpawell
reviewed
Sep 11, 2024
End-rey
force-pushed
the
2853-list-objects-via-control-service
branch
from
07ad41e
to
e6a62c9
Compare
carpawell
reviewed
Sep 12, 2024
|
|
||
| cli := getClient(ctx, cmd) | ||
|
|
||
| var resp []*control.ListObjectsResponse |
There was a problem hiding this comment.
my stream request was mostly about memory consumption and user experience: if we received some info, we can print it and drop it from memory. if we are about to download e.g. 100mb it will take seconds of no output for a user. can you try not to hold every streamed message in memory?
There was a problem hiding this comment.
I thought about it, but I couldn't find a good solution. Now I've done it using the function inside.
End-rey
force-pushed
the
2853-list-objects-via-control-service
branch
from
e6a62c9
to
43c552a
Compare
End-rey
force-pushed
the
2853-list-objects-via-control-service
branch
from
43c552a
to
375652d
Compare
End-rey
force-pushed
the
2853-list-objects-via-control-service
branch
from
375652d
to
56574f4
Compare
|
some code became deprecated with 5bbbf04, fix pls |
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use `google.golang.org/protobuf` instead of `github.com/golang/protobuf` since the official repository recommends it using: https://github.com/golang/protobuf. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Includes API definition extending; server side streaming RPC implementation; protoc version update. The command requests server's storage engine list of objects, that are known by node. Does not include inhumed objects. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Support command that gets list of objects in node. Create separate file for `control object` commands. ``` $ neofs-cli control object list --endpoint s01.neofs.devenv:8081 -w services/storage/wallet01.json Enter password > A2FtcmZh76XqAym55fkCvzfB7dJ5dUt3fuGzQitGkW7S/CxSt4cFbwMtnuKHjqEjsWjctdfVWWTZqLkXheLHxjn4p HimRwmgw4PNasobAxGwVMCmV45rkjvYkYdV7toDoavMu/2YCzyvgz9HMfyBAAbGNmcsq98serp77hzJuc6F4qSz5w HimRwmgw4PNasobAxGwVMCmV45rkjvYkYdV7toDoavMu/2hgSnzrZHaQZLxLNXz4XEGbHdB9Y1zUjDZa3Z1foBnma $ neofs-cli control object list --endpoint s02.neofs.devenv:8081 -w services/storage/wallet02.json Enter password > HimRwmgw4PNasobAxGwVMCmV45rkjvYkYdV7toDoavMu/GrHcAXjgWiS69iVXBpe8YGKx1H23rBbfTCBL5WojaoSw $ neofs-cli control object list --endpoint s03.neofs.devenv:8081 -w services/storage/wallet03.json Enter password > A2FtcmZh76XqAym55fkCvzfB7dJ5dUt3fuGzQitGkW7S/5rTDeZTrgMt3DZE8nbT6sKFn1MiZUKZu4Gfk7cFrW7WY HimRwmgw4PNasobAxGwVMCmV45rkjvYkYdV7toDoavMu/2hgSnzrZHaQZLxLNXz4XEGbHdB9Y1zUjDZa3Z1foBnma HimRwmgw4PNasobAxGwVMCmV45rkjvYkYdV7toDoavMu/GrHcAXjgWiS69iVXBpe8YGKx1H23rBbfTCBL5WojaoSw 4rj9mynn8tijZFK9mgdG1Zc2fjwdEJstwYC2iYRM8skw/CRuojN8Lv6nzyoEfQ4FEPWdZxSSAtM2rqQPMuZLMePJQ A2FtcmZh76XqAym55fkCvzfB7dJ5dUt3fuGzQitGkW7S/CxSt4cFbwMtnuKHjqEjsWjctdfVWWTZqLkXheLHxjn4p HimRwmgw4PNasobAxGwVMCmV45rkjvYkYdV7toDoavMu/2YCzyvgz9HMfyBAAbGNmcsq98serp77hzJuc6F4qSz5w $ neofs-cli control object list --endpoint s04.neofs.devenv:8081 -w services/storage/wallet04.json Enter password > 4rj9mynn8tijZFK9mgdG1Zc2fjwdEJstwYC2iYRM8skw/CRuojN8Lv6nzyoEfQ4FEPWdZxSSAtM2rqQPMuZLMePJQ A2FtcmZh76XqAym55fkCvzfB7dJ5dUt3fuGzQitGkW7S/5rTDeZTrgMt3DZE8nbT6sKFn1MiZUKZu4Gfk7cFrW7WY ``` Closes #2853. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
2853-list-objects-via-control-service
branch
from
7a8bbdb
to
ac28d57
Compare
Use `grpc.NewClient` instead of `grpc.DialContext`. According https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md don't use `WithBlock`. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
2853-list-objects-via-control-service
branch
from
ac28d57
to
e0af43c
Compare
cthulhu-rider
approved these changes
Sep 18, 2024
roman-khimov
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2853.