Feat/add meta indexes inspection to lens #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
feat/add-meta-indexes-inspection-to-lens
branch
from
347166c
to
44f1975
Compare
Panic can happen otherwise. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/add-meta-indexes-inspection-to-lens
branch
from
44f1975
to
30e6691
Compare
Seems like a regression from the 8fd1b16, peapod has "peapod" ID. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/add-meta-indexes-inspection-to-lens
branch
2 times, most recently
from
490e3db
to
081280d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2882 +/- ##
==========================================
+ Coverage 23.61% 23.70% +0.09%
==========================================
Files 770 772 +2
Lines 44527 44677 +150
==========================================
+ Hits 10514 10591 +77
- Misses 33163 33235 +72
- Partials 850 851 +1 ☔ View full report in Codecov by Sentry. |
|
essentially looks good |
|
@carpawell can we say this relates to #2506? |
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/add-meta-indexes-inspection-to-lens
branch
from
081280d
to
6edc5c0
Compare
No, it is more like a #2844's helper. But i would not mention it. |
cthulhu-rider
approved these changes
Jul 3, 2024
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Every bucket has a _prefix_ in its name, it is always the first byte, and current docs may confuse about byte order. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/add-meta-indexes-inspection-to-lens
branch
from
6edc5c0
to
c02ad89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.