-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage list for lens #2852
Storage list for lens #2852
Conversation
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2852 +/- ##
==========================================
- Coverage 23.66% 23.65% -0.02%
==========================================
Files 769 770 +1
Lines 44533 44514 -19
==========================================
- Hits 10540 10531 -9
+ Misses 33142 33129 -13
- Partials 851 854 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good
desc says that cmd lists objects in blobstor. At the same time, it does not access the blobstor, only metabase is read. May be this worth to be clarified
Signed-off-by: Roman Khimov <roman@nspcc.ru>
ceaf7a3
to
04a482e
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov, as @cthulhu-rider said that is a meta operation and the lens' meta
subcommand already has it, so why do we need it? It can be confusing.
defer storage.Close() | ||
|
||
var p engine.ListWithCursorPrm | ||
p.WithCount(1024) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
magic? can lose 1025-th object and do not understand it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will list everything. Yeah, magic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, almost endless for
, did not see it. check context b/w iteration then to make it controllable?
IIUC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The work is done and it does what it claims so OK, but I would not add this command as the blobstor is a too complex thing to inspect IMO, and it is not about storage only but about managing and background processes too. Also, it is changed quite often.
No description provided.