Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage list for lens #2852

Merged
merged 2 commits into from
May 22, 2024
Merged

Storage list for lens #2852

merged 2 commits into from
May 22, 2024

Conversation

roman-khimov
Copy link
Member

No description provided.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov added the neofs-lens NeoFS Lens app issues label May 20, 2024
@roman-khimov roman-khimov added this to the v0.42.0 milestone May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 23.65%. Comparing base (5533aa8) to head (04a482e).
Report is 7 commits behind head on master.

Files Patch % Lines
cmd/neofs-lens/internal/storage/list.go 0.00% 19 Missing ⚠️
cmd/neofs-lens/internal/storage/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2852      +/-   ##
==========================================
- Coverage   23.66%   23.65%   -0.02%     
==========================================
  Files         769      770       +1     
  Lines       44533    44514      -19     
==========================================
- Hits        10540    10531       -9     
+ Misses      33142    33129      -13     
- Partials      851      854       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall good

desc says that cmd lists objects in blobstor. At the same time, it does not access the blobstor, only metabase is read. May be this worth to be clarified

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov
Copy link
Member Author

May be this worth to be clarified

Done.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-khimov, as @cthulhu-rider said that is a meta operation and the lens' meta subcommand already has it, so why do we need it? It can be confusing.

defer storage.Close()

var p engine.ListWithCursorPrm
p.WithCount(1024)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic? can lose 1025-th object and do not understand it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will list everything. Yeah, magic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, almost endless for, did not see it. check context b/w iteration then to make it controllable?

@roman-khimov
Copy link
Member Author

IIUC meta requires going over all metabases, also I think this one can be made to work without metabase.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work is done and it does what it claims so OK, but I would not add this command as the blobstor is a too complex thing to inspect IMO, and it is not about storage only but about managing and background processes too. Also, it is changed quite often.

@roman-khimov roman-khimov merged commit a040d85 into master May 22, 2024
17 of 20 checks passed
@roman-khimov roman-khimov deleted the storage-list branch May 22, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neofs-lens NeoFS Lens app issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants