node: Return status responses only #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoFS statuses were introduced a long time ago. Until now, the server supported responses to "old" clients with gRPC statuses. However, now this approach is considered incorrect since it does not allow integrating applications with the NeoFS behavioral model. Refs #961. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2846 +/- ##
==========================================
+ Coverage 23.63% 23.64% +0.01%
==========================================
Files 769 769
Lines 44594 44572 -22
==========================================
Hits 10541 10541
+ Misses 33202 33180 -22
Partials 851 851 ☔ View full report in Codecov by Sentry. |
roman-khimov
reviewed
May 7, 2024
| if err = signature.SignServiceMessage(s.key, resp); err != nil { | ||
| // We can't pass this error as status code since response will be unsigned. | ||
| // Isn't expected in practice, so panic is ok here. | ||
| panic(err) |
There was a problem hiding this comment.
Brutal. We can log and close the connection.
roman-khimov
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for non-status returns makes no sense after such a period