neofs-adm: Add container estimations inspector #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
force-pushed
the
feat/estimations-inspector
branch
2 times, most recently
from
207ead8
to
16c3ca6
Compare
roman-khimov
approved these changes
Apr 22, 2024
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
feat/estimations-inspector
branch
from
16c3ca6
to
40e1ab0
Compare
roman-khimov
added a commit
that referenced
this pull request
Apr 27, 2024
And use a bit more of NNS wrapper. Notice that this changes "alphabet X" to "alphabetX" in dump output, but I consider this to be an improvement (since that's the contract name). It also deoptimizes some carefully crafted code to extract a number of names in one call. Likely it's not a performance issue you care about and it's actually somewhat broken in that it assumes one result per invocation (but you can get zero or more than one). Many more things can be improved, but let's start with this. Refs. #2826. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this pull request
Apr 27, 2024
And use a bit more of NNS wrapper. Notice that this changes "alphabet X" to "alphabetX" in dump output, but I consider this to be an improvement (since that's the contract name). It also deoptimizes some carefully crafted code to extract a number of names in one call. Likely it's not a performance issue you care about and it's actually somewhat broken in that it assumes one result per invocation (but you can get zero or more than one). Many more things can be improved, but let's start with this. Refs. #2826. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this pull request
May 2, 2024
And use a bit more of NNS wrapper. Notice that this changes "alphabet X" to "alphabetX" in dump output, but I consider this to be an improvement (since that's the contract name). It also deoptimizes some carefully crafted code to extract a number of names in one call. Likely it's not a performance issue you care about and it's actually somewhat broken in that it assumes one result per invocation (but you can get zero or more than one). Many more things can be improved, but let's start with this. Refs. #2826. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this pull request
May 2, 2024
And use a bit more of NNS wrapper. Notice that this changes "alphabet X" to "alphabetX" in dump output, but I consider this to be an improvement (since that's the contract name). It also deoptimizes some carefully crafted code to extract a number of names in one call. Likely it's not a performance issue you care about and it's actually somewhat broken in that it assumes one result per invocation (but you can get zero or more than one). Many more things can be improved, but let's start with this. Refs. #2826. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.