Fix/GAS consumption by SN #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2777 +/- ##
=======================================
Coverage 22.04% 22.04%
=======================================
Files 787 787
Lines 46738 46738
=======================================
+ Hits 10302 10304 +2
+ Misses 35553 35552 -1
+ Partials 883 882 -1 ☔ View full report in Codecov by Sentry. |
carpawell
force-pushed
the
fix/GAS-consumption-by-SN
branch
from
42607cc
to
6ca1bcc
Compare
carpawell
force-pushed
the
fix/GAS-consumption-by-SN
branch
5 times, most recently
from
e5d4bec
to
adca20d
Compare
CHANGELOG.md
Outdated
| @@ -19,6 +19,7 @@ Changelog for NeoFS Node | |||
| - IR now checks format of NULL and numeric eACL filters specified in the protocol (#2742) | |||
| - Empty filter value is now treated as `NOT_PRESENT` op by CLI `acl extended create` cmd (#2742) | |||
| - Storage nodes no longer accept objects with header larger than 16KB (#2749) | |||
| - IR sends neofs chain GAS to netmap nodes every epoch, not per a configurable blocks number (#2777) | |||
There was a problem hiding this comment.
Suggested change
| - IR sends neofs chain GAS to netmap nodes every epoch, not per a configurable blocks number (#2777) | |
| - IR sends NeoFS chain GAS to netmap nodes every epoch, not per configurable blocks' number (#2777) |
carpawell
force-pushed
the
fix/GAS-consumption-by-SN
branch
from
adca20d
to
1812e63
Compare
They are not called by the Alphabet anymore, the original methods are used and resigned. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
It is safe to be here (not used before `initNetmapService` is called) and it was not clear why `initMorphComponents` inits anything outside the `cfgMorph` struct. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Know about GAS distribution if something bad happens. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Do not wait for a configurable number of blocks, make it every epoch instead. Most of the processes are bound to epochs, also `newEpoch` event may be triggered by an external TX sender, so GAS consumption may increase while GAS distribution is the same. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
fix/GAS-consumption-by-SN
branch
from
1812e63
to
0a35431
Compare
roman-khimov
approved these changes
Mar 20, 2024
cthulhu-rider
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.