acl: Perceive tombstone saving as delete operation #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
- Coverage 28.88% 28.86% -0.03%
==========================================
Files 415 415
Lines 32478 32485 +7
==========================================
- Hits 9382 9376 -6
- Misses 22254 22265 +11
- Partials 842 844 +2 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
2261-put-tombstone-is-delete
branch
from
58cc445
to
0973b2e
Compare
roman-khimov
approved these changes
Feb 26, 2024
cthulhu-rider
force-pushed
the
2261-put-tombstone-is-delete
branch
3 times, most recently
from
e3f163f
to
2816d8f
Compare
Previously, storage nodes handled `ObjectService.Put` requests regardless of object types. Since writing tombstones is essentially an operation of removing objects from their context, this opened up a security issue: granting the right to write objects into the container automatically granted the right to delete any objects from it. This, on the one hand, implicit, on the other hand, strange behavior would raise obvious questions about practical access control in the system. From now, `PUT` ops of `TOMBSTONE` objects are treated as `DELETE`. The only exclusion is intra-container replication that still should be performed in `PUT` manner (container nodes have no removal rights). Closes #2261. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
2261-put-tombstone-is-delete
branch
from
2816d8f
to
a7eb6ec
Compare
carpawell
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.