rm/System role access changes in eACL #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2547 +/- ##
=======================================
Coverage 29.67% 29.67%
=======================================
Files 405 405
Lines 30756 30758 +2
=======================================
+ Hits 9126 9128 +2
- Misses 20860 20861 +1
+ Partials 770 769 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
carpawell
force-pushed
the
rm/system-role-access-changes-in-eACL
branch
from
e6cb752
to
c3b9483
Compare
carpawell
requested review from
roman-khimov and
cthulhu-rider
as code owners
|
OK after #2489. |
carpawell
force-pushed
the
rm/system-role-access-changes-in-eACL
branch
from
c3b9483
to
c82e461
Compare
OK, added |
Refs nspcc-dev#2531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Closes nspcc-dev#2531. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
force-pushed
the
rm/system-role-access-changes-in-eACL
branch
from
c82e461
to
ab909a3
Compare
roman-khimov
approved these changes
Sep 8, 2023
cthulhu-rider
approved these changes
Sep 11, 2023
| @@ -92,3 +97,15 @@ func (cp *Processor) approveSetEACL(e container.SetEACL) { | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| func validateEACl(t *eacl.Table) error { | |||
There was a problem hiding this comment.
L lowered intentionally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.