neofs-adm: init and update-contracts are the only commands for wallets creation #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
AliceInHunterland
force-pushed
the
bugfix/2134-neofs-adm-contract-wallet
branch
3 times, most recently
from
2b66714
to
4c8add3
Compare
roman-khimov
requested changes
Aug 16, 2023
AliceInHunterland
force-pushed
the
bugfix/2134-neofs-adm-contract-wallet
branch
2 times, most recently
from
856e9d8
to
cdf932e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2515 +/- ##
=======================================
Coverage 29.68% 29.69%
=======================================
Files 404 404
Lines 30711 30711
=======================================
+ Hits 9117 9119 +2
+ Misses 20825 20824 -1
+ Partials 769 768 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AliceInHunterland
force-pushed
the
bugfix/2134-neofs-adm-contract-wallet
branch
7 times, most recently
from
0173ee5
to
b75460a
Compare
The only command that can create alphabet wallets is init. The only commands that can create contract wallet are init and update-contracts. Closes #2134. Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
bugfix/2134-neofs-adm-contract-wallet
branch
from
b75460a
to
01a1c99
Compare
cthulhu-rider
approved these changes
Aug 17, 2023
roman-khimov
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added checks for commands before wallet creation
Closes #2134.