morph: use Notary Actor for notary requests submission#2310
Merged
roman-khimov merged 2 commits intomasterfrom Apr 21, 2023
Merged
morph: use Notary Actor for notary requests submission#2310roman-khimov merged 2 commits intomasterfrom
roman-khimov merged 2 commits intomasterfrom
Conversation
AnnaShaleva
force-pushed
the
use-notarizator
branch
from
890bf06 to
961666c
Compare
Member
Author
|
Checked on the dev-env against the nspcc-dev/neo-go#2955, SNs are able to properly enter the netmap: |
Codecov Report
@@ Coverage Diff @@
## master #2310 +/- ##
==========================================
+ Coverage 29.94% 30.01% +0.07%
==========================================
Files 400 400
Lines 30269 30205 -64
==========================================
+ Hits 9063 9066 +3
+ Misses 20467 20400 -67
Partials 739 739
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
requested changes
Apr 19, 2023
| }...) | ||
|
|
||
| if len(mainTx.Signers) > 3 { | ||
| // Invoker signature (simple signature account of storage node is expected). |
Member
There was a problem hiding this comment.
Then a fake one works fine as well, we're only supposed to be adding IR signatures now (we don't have any other cases for now), so we don't care who is the third signer, a correct signature is supposed to be present there anyway.
Member
Author
There was a problem hiding this comment.
The problem is that to create a proper notary.FakeSimpleAccount(pub) we need to parse existing verification script to get the pub out of it. The same problem with multisig account. And I'd like to completely avoid parsing, it's just not needed here and this signer is unesed anyway.
AnnaShaleva
force-pushed
the
use-notarizator
branch
from
961666c to
4e52720
Compare
AnnaShaleva
force-pushed
the
use-notarizator
branch
2 times, most recently
from
7ed29f9 to
bdc463a
Compare
roman-khimov
previously approved these changes
Apr 21, 2023
AnnaShaleva
force-pushed
the
use-notarizator
branch
from
70e0423 to
51f907c
Compare
AnnaShaleva
dismissed
roman-khimov’s stale review
Backwards compatibility code is added to the notary preparator.
And adjust the way how newly-created SN notary request is defined. Notary actor doesn't fill dummy witness for multisignature account (and that's the way how the system is supposed to function, see the documentation 7-th instruction at https://github.com/nspcc-dev/neo-go/blob/master/docs/notary.md#2-request-submission). Thus, to check the request was just received from the storage node we must ensure the inner ring witness has empty invocation script. That was the reason of nspcc-dev/neo-go#2955. Signed-off-by: Anna Shaleva <anna@nspcc.ru>
It's unused and not needed, default fallback lifetime is set by Notary actor. Signed-off-by: Anna Shaleva <anna@nspcc.ru>
AnnaShaleva
force-pushed
the
use-notarizator
branch
from
51f907c to
d45e68c
Compare
roman-khimov
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a tiny part of neo-go version upgrade.
And adjust the way how newly-created SN notary request is defined. Notary actor doesn't fill dummy witness for multisignature account (and that's the way how the system is supposed to function, see the documentation 7-th instruction at
https://github.com/nspcc-dev/neo-go/blob/master/docs/notary.md#2-request-submission). Thus, to check the request was just received from the storage node we must ensure the inner ring witness has empty invocation script.
That was the reason of nspcc-dev/neo-go#2955.
Refs. nspcc-dev/neo-go#2981.
TODO: