node: Increase default replication timeout to 1 minute #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
added
neofs-storage
cthulhu-rider
added a commit
to cthulhu-rider/neofs-node
that referenced
this pull request
Jan 31, 2023
Storage node's replication timeout usually not carefully tuned and in most cases remains the default. Previously it was 5s, which might not be enough for "highly distributed" networks (such as TestNet or MainNet). Increase `replicator.put_timeout` config default to `1m`. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider
force-pushed
the
config/increate-replicator-timeout-default
branch
from
fec0867
to
ac466e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2227 +/- ##
=======================================
Coverage 30.71% 30.71%
=======================================
Files 383 383
Lines 28277 28277
=======================================
Hits 8685 8685
Misses 18862 18862
Partials 730 730
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Storage node's replication timeout usually not carefully tuned and in most cases remains the default. Previously it was 5s, which might not be enough for "highly distributed" networks (such as TestNet or MainNet). Increase `replicator.put_timeout` config default to `1m`. Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
cthulhu-rider
force-pushed
the
config/increate-replicator-timeout-default
branch
from
ac466e7
to
10bd776
Compare
roman-khimov
approved these changes
Jan 31, 2023
cthulhu-rider
requested review from
alexvanin,
carpawell and
fyrchik
as code owners
fyrchik
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by MainNet. "Fast" networks are considered more rare and requiring detailed configuration.