Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network/cache: do not reconnect to failed clients immediately #2164

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Dec 19, 2022

Close #2054.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #2164 (ddf26df) into master (dc9d41e) will increase coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head ddf26df differs from pull request most recent head 461e3bd. Consider uploading reports for the commit 461e3bd to get more accurate results

@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   30.75%   30.77%   +0.02%     
==========================================
  Files         382      382              
  Lines       28230    28101     -129     
==========================================
- Hits         8681     8649      -32     
+ Misses      18818    18718     -100     
- Partials      731      734       +3     
Impacted Files Coverage Δ
cmd/neofs-node/config.go 0.00% <0.00%> (ø)
cmd/neofs-node/config/apiclient/config.go 100.00% <100.00%> (ø)
pkg/local_object_storage/shard/get.go 77.58% <0.00%> (-9.09%) ⬇️
pkg/local_object_storage/writecache/put.go 65.85% <0.00%> (-5.58%) ⬇️
pkg/local_object_storage/shard/lock.go 50.00% <0.00%> (-4.55%) ⬇️
pkg/local_object_storage/shard/list.go 21.15% <0.00%> (-2.93%) ⬇️
pkg/local_object_storage/shard/delete.go 69.76% <0.00%> (-1.98%) ⬇️
pkg/local_object_storage/shard/put.go 81.25% <0.00%> (-1.11%) ⬇️
...ct_storage/blobstor/blobovniczatree/blobovnicza.go 62.65% <0.00%> (-0.88%) ⬇️
pkg/local_object_storage/writecache/init.go 93.54% <0.00%> (-0.74%) ⬇️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The last commit is not formatted;
  2. reconnect_timeout confuses me, I would name that smth like reconnect_interval like you did in the code. /cc @realloc, @anatoly-bogatyrev

clients: make(map[string]*singleClient),
addr: addr,
opts: opts,
reconnectInterval: defaultReconnectInterval,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about that line?

@sami-nspcc
Copy link

Test run is finished. Please download the tarball from link. Untar and use allure open to watch the report. Build number is 3858

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
…mediately

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
@fyrchik
Copy link
Contributor Author

fyrchik commented Dec 27, 2022

@anikeev-yadro tested this on a hardware.

@sami-nspcc
Copy link

Test run is finished. Please download the tarball from link. Untar and use allure open to watch the report. Build number is 3876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3 PUT errors on AZ when we rebooted VEDI.
4 participants