-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network/cache: do not reconnect to failed clients immediately #2164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
+ Coverage 30.75% 30.77% +0.02%
==========================================
Files 382 382
Lines 28230 28101 -129
==========================================
- Hits 8681 8649 -32
+ Misses 18818 18718 -100
- Partials 731 734 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The last commit is not formatted;
reconnect_timeout
confuses me, I would name that smth likereconnect_interval
like you did in the code. /cc @realloc, @anatoly-bogatyrev
clients: make(map[string]*singleClient), | ||
addr: addr, | ||
opts: opts, | ||
reconnectInterval: defaultReconnectInterval, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about that line?
Test run is finished. Please download the tarball from link. Untar and use |
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
…mediately Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
@anikeev-yadro tested this on a hardware. |
Test run is finished. Please download the tarball from link. Untar and use |
Close #2054.