Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT] Fix/Big objects removal with static sessions #2036

Merged
merged 1 commit into from
Nov 12, 2022
Merged

[SUPPORT] Fix/Big objects removal with static sessions #2036

merged 1 commit into from
Nov 12, 2022

Conversation

carpawell
Copy link
Member

If an external session is provided and is not opened by CLI itself, add children objects to it too. It fixes "not found" errors when removing a big object with a predefined session (from a file).

Signed-off-by: Pavel Karpy carpawell@nspcc.ru

Closes #1978.

If an external session is provided and is not opened by CLI itself, add
children objects to it too. It fixes "not found" errors when removing a big
object with a predefined session (from a file).

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #2036 (afc270e) into support/v0.34 (c38ad2d) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           support/v0.34    #2036   +/-   ##
==============================================
  Coverage          30.57%   30.57%           
==============================================
  Files                380      380           
  Lines              27790    27790           
==============================================
  Hits                8497     8497           
  Misses             18593    18593           
  Partials             700      700           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Nov 10, 2022

Documentation says that delete command doesn't support static sessions. I suppose object delete shouldn't accept session flag.

@carpawell
Copy link
Member Author

Documentation says that delete command doesn't support static sessions.

@cthulhu-rider, is there any reason for that?

@cthulhu-rider
Copy link
Contributor

is there any reason for that?

Yes: currently session secret key must be allocated on the node served on --rpc-endpoint. Attaching pre-created session token doesn't make any sense (now).

@carpawell
Copy link
Member Author

carpawell commented Nov 10, 2022

Attaching pre-created session token doesn't make any sense (now).

@cthulhu-rider, the issue that PR closes appeared by validating (auto tests) the following case: neofs-cli session create + neofs-cli object put + neofs-cli object delete. Valid case, no?

@carpawell carpawell marked this pull request as draft November 10, 2022 09:06
@carpawell carpawell marked this pull request as ready for review November 11, 2022 09:09
@fyrchik fyrchik merged commit f6f911b into nspcc-dev:support/v0.34 Nov 12, 2022
@carpawell carpawell deleted the fix/big-objects-removal-with-static-sessions branch November 12, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants