-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUPPORT] Fix/Big objects removal with static sessions #2036
[SUPPORT] Fix/Big objects removal with static sessions #2036
Conversation
If an external session is provided and is not opened by CLI itself, add children objects to it too. It fixes "not found" errors when removing a big object with a predefined session (from a file). Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## support/v0.34 #2036 +/- ##
==============================================
Coverage 30.57% 30.57%
==============================================
Files 380 380
Lines 27790 27790
==============================================
Hits 8497 8497
Misses 18593 18593
Partials 700 700 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Documentation says that |
@cthulhu-rider, is there any reason for that? |
Yes: currently session secret key must be allocated on the node served on |
@cthulhu-rider, the issue that PR closes appeared by validating (auto tests) the following case: |
If an external session is provided and is not opened by CLI itself, add children objects to it too. It fixes "not found" errors when removing a big object with a predefined session (from a file).
Signed-off-by: Pavel Karpy carpawell@nspcc.ru
Closes #1978.