writecache: flush cache when moving to the DEGRADED mode #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
+ Coverage 31.06% 31.08% +0.01%
==========================================
Files 374 374
Lines 26377 26384 +7
==========================================
+ Hits 8195 8202 +7
Misses 17492 17492
Partials 690 690
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acid-ant
previously approved these changes
Sep 30, 2022
carpawell
previously approved these changes
Oct 4, 2022
| @@ -59,7 +59,7 @@ func (c *cache) runFlushLoop() { | |||
| }() | |||
| } | |||
|
|
|||
| func (c *cache) flush() { | |||
| func (c *cache) flushDB() { | |||
There was a problem hiding this comment.
Because we already have OpenDB
…mode Degraded mode allows us to operate without an SSD, thus writecache should be unavailable in this mode. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
carpawell
approved these changes
Oct 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
…mode Degraded mode allows us to operate without an SSD, thus writecache should be unavailable in this mode. Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Degraded mode allows us to operate without an SSD, thus writecache should be unavailable in this mode.
Signed-off-by: Evgenii Stratonikov evgeniy@morphbits.ru