Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of nodeinfo command #1821

Merged

Conversation

vdomnich-yadro
Copy link
Contributor

Description updated because the command returns information about the remote node that is listening to the --rpc-endpoint

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1821 (5f9375d) into master (0a41190) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   31.00%   31.00%           
=======================================
  Files         374      374           
  Lines       26175    26175           
=======================================
  Hits         8116     8116           
  Misses      17377    17377           
  Partials      682      682           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fyrchik
fyrchik previously approved these changes Sep 28, 2022
@fyrchik
Copy link
Contributor

fyrchik commented Sep 28, 2022

Could you also prefix the commit with [#...] neofs-cli: Fix description ...?

1. nodeinfo - updated description of node.
2. eacl - fixed misprint.

Signed-off-by: Vladimir Domnich <v.domnich@yadro.com>
@vdomnich-yadro
Copy link
Contributor Author

Could you also prefix the commit with [#...] neofs-cli: Fix description ...?

Done!

P.S. I don't have permissions for merging, so I can't merge the PR myself)

@fyrchik fyrchik merged commit 5284ac5 into nspcc-dev:master Sep 28, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
1. nodeinfo - updated description of node.
2. eacl - fixed misprint.

Signed-off-by: Vladimir Domnich <v.domnich@yadro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants