-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Add meta to neofs-lens
#1714
Feat/Add meta to neofs-lens
#1714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
- Coverage 33.19% 32.55% -0.64%
==========================================
Files 351 337 -14
Lines 23422 22667 -755
==========================================
- Hits 7774 7380 -394
+ Misses 14997 14674 -323
+ Partials 651 613 -38
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
db := meta.New( | ||
meta.WithPath(vPath), | ||
meta.WithBoltDBOptions(&bbolt.Options{ | ||
ReadOnly: true, | ||
Timeout: 100 * time.Millisecond, | ||
}), | ||
meta.WithEpochState(epochState{}), | ||
) | ||
|
||
common.ExitOnErr(cmd, common.Errf("could not open metabase: %w", db.Open(true))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move all 3 calls in this package in a single parameterless function? They have the same purpose -- open DB in readonly to view sth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, added such funcs for all the components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For future pls don't blend feature code with refactor
Separate `inspect` and `list` on `write-cache` and `blobovnicza` subcommands. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Usually, I do not do PRs that way. That happened because of the order of my changes: first, i added the meta but then realized that it was incredibly hard to use it without a refactor (and separate the refactor from the feature, so that is not refactoring for refactoring, just adding the meta make usage hard). In fact, commits are quite independent now. Rebased CHANGELOG conflicts. |
Includes: 1. `inspect` 2. `list-garbage` 3. `list-graveyard` Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Separate `inspect` and `list` on `write-cache` and `blobovnicza` subcommands. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Includes: 1. `inspect` 2. `list-garbage` 3. `list-graveyard` Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Separate `inspect` and `list` on `write-cache` and `blobovnicza` subcommands. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Includes: 1. `inspect` 2. `list-garbage` 3. `list-graveyard` Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Adds
meta
subcommand. Also, includes refactoring that separatesinspect
andlist
commands onwrite-cache
andblobovnicza
subcommands.