Fix/Slow meta search on COMMON_PREFIX
#1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
- Coverage 33.17% 33.16% -0.02%
==========================================
Files 332 332
Lines 22709 22726 +17
==========================================
+ Hits 7534 7536 +2
- Misses 14557 14571 +14
- Partials 618 619 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Checked on rclone tests - everything ok |
carpawell
requested review from
fyrchik,
cthulhu-rider,
KirillovDenis and
realloc
cthulhu-rider
previously approved these changes
Aug 4, 2022
Return all the objects on the empty common prefix search without search optimizations that breaks boltDB logic. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
cthulhu-rider
approved these changes
Aug 4, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Return all the objects on the empty common prefix search without search optimizations that breaks boltDB logic. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1577. Seems like a fix but I would return to make sure that one more time.