Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Support EACL_NOT_FOUND status #1645

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Feat/Support EACL_NOT_FOUND status #1645

merged 2 commits into from
Aug 1, 2022

Conversation

carpawell
Copy link
Member

Remove internal ErrEACLNotFound error.
Also, update neofs-api-go and and neofs-sdk-library.

Signed-off-by: Pavel Karpy carpawell@nspcc.ru

Related to nspcc-dev/neofs-sdk-go#305.

@carpawell carpawell added the enhancement Improving existing functionality label Aug 1, 2022
@carpawell carpawell self-assigned this Aug 1, 2022
- `neofs-api-go` to `v2.13.1`;
- `neofs-sdk-go` to `7a99cc916c8e`.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Remove internal `ErrEACLNotFound` error.
Also, update `neofs-api-go` and `neofs-sdk-go` libraries.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1645 (d1b5223) into master (8ffc2fd) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   33.16%   33.17%           
=======================================
  Files         332      332           
  Lines       22714    22714           
=======================================
+ Hits         7534     7536    +2     
+ Misses      14561    14560    -1     
+ Partials      619      618    -1     
Impacted Files Coverage Δ
pkg/services/object/acl/acl.go 30.23% <0.00%> (ø)
pkg/local_object_storage/engine/range.go 53.76% <0.00%> (+2.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@carpawell carpawell marked this pull request as ready for review August 1, 2022 17:32
@carpawell carpawell merged commit c2918fc into nspcc-dev:master Aug 1, 2022
carpawell added a commit that referenced this pull request Aug 1, 2022
- `neofs-api-go` to `v2.13.1`;
- `neofs-sdk-go` to `7a99cc916c8e`.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell deleted the feat/eacl-not-found-code branch August 1, 2022 17:45
carpawell added a commit that referenced this pull request Aug 1, 2022
- `neofs-api-go` to `v2.13.1`;
- `neofs-sdk-go` to `7a99cc916c8e`.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
(cherry picked from commit 8c8ae56)
carpawell added a commit that referenced this pull request Aug 1, 2022
Remove internal `ErrEACLNotFound` error.
Also, update `neofs-api-go` and `neofs-sdk-go` libraries.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
(cherry picked from commit c2918fc)
@alexchetaev alexchetaev added the U3 Regular label Aug 23, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
- `neofs-api-go` to `v2.13.1`;
- `neofs-sdk-go` to `7a99cc916c8e`.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
Remove internal `ErrEACLNotFound` error.
Also, update `neofs-api-go` and `neofs-sdk-go` libraries.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality U3 Regular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants