Feat/Support changing network config in adm
#1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carpawell
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
- Coverage 35.65% 35.56% -0.10%
==========================================
Files 305 305
Lines 18212 18273 +61
==========================================
+ Hits 6494 6498 +4
- Misses 11168 11225 +57
Partials 550 550
Continue to review full report at Codecov.
|
fyrchik
reviewed
Jul 8, 2022
Comment on lines
288
to
289
| // print some warning that user | ||
| // want to add some unknown config? |
There was a problem hiding this comment.
Maybe add --force flag to this command? Then fail here if it is missing.
fyrchik
previously approved these changes
Jul 12, 2022
| return fmt.Errorf("can't get netmap contract hash: %w", err) | ||
| } | ||
|
|
||
| forceFlag, err := cmd.Flags().GetBool(forceConfigSet) |
There was a problem hiding this comment.
hm, yes, we do ignore that kind of error usually. dropped that check
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
fyrchik
approved these changes
Jul 12, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.