Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neofs-adm: do not update NNS group if the key is the same #1375

Merged
merged 1 commit into from
May 13, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented May 12, 2022

If the group key is already set, do not send any transactions.

Signed-off-by: Evgenii Stratonikov evgeniy@nspcc.ru

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1375 (482bc39) into master (3a188bb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   34.92%   34.92%           
=======================================
  Files         313      313           
  Lines       19638    19638           
=======================================
  Hits         6859     6859           
  Misses      12231    12231           
  Partials      548      548           
Impacted Files Coverage Δ
...neofs-adm/internal/modules/morph/initialize_nns.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a188bb...482bc39. Read the comment docs.

Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fyrchik CHANGELOG, pls

… same

If the group key is already set, do not send any transactions.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
@cthulhu-rider cthulhu-rider merged commit 57200e1 into nspcc-dev:master May 13, 2022
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
… same

If the group key is already set, do not send any transactions.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neofs-adm NeoFS Adm application issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants